Skip to content

Durable Queue #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 19, 2025
Merged

Durable Queue #459

merged 7 commits into from
Mar 19, 2025

Conversation

conico974
Copy link
Collaborator

@conico974 conico974 commented Mar 13, 2025 •
edited
Loading

This PR implements a Durable Object for the Queue allowing proper deduplication of the ISR request.
I'll add handling of eventually consistent Incremental Cache (such as KV or using withRegionalCache from James PR) in another PR

The PR is split into 2 parts, this one and the one in #460 that add storage to it

This is part 1 of 2 in a stack made with GitButler:

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b18d4fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@459

commit: b18d4fe

@conico974 conico974 force-pushed the conico/durable-queue branch from 410c4ea to 96e3168 Compare March 13, 2025 10:40
vicb
vicb reviewed Mar 13, 2025
View reviewed changes
@conico974 conico974 mentioned this pull request Mar 13, 2025
Merged
@conico974 conico974 changed the title [WIP] Durable Queue Durable Queue Mar 13, 2025
@conico974 conico974 marked this pull request as ready for review March 13, 2025 18:06
@conico974 conico974 force-pushed the conico/durable-queue branch from a8776ad to 2b9832d Compare March 17, 2025 12:15
@conico974 conico974 force-pushed the conico/durable-queue branch from 2b9832d to 0a49f3c Compare March 17, 2025 16:04
@conico974 conico974 mentioned this pull request Mar 17, 2025
Merged
@conico974 conico974 requested a review from vicb March 17, 2025 18:32
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
vicb
vicb reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll review one more in the morning tomorrow.
Added a few minor comments

vicb
vicb reviewed Mar 19, 2025
View reviewed changes
vicb
vicb reviewed Mar 19, 2025
View reviewed changes
vicb
vicb reviewed Mar 19, 2025
View reviewed changes
vicb
vicb approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.
Thanks!

@conico974 conico974 merged commit 9f32a0f into main Mar 19, 2025
7 checks passed
@conico974 conico974 deleted the conico/durable-queue branch March 19, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@conico974 @vicb